Skip to content

fix(i18n): german translation for "hit" in a11y section + missing keys#1493

Open
TheDevMinerTV wants to merge 3 commits intonpmx-dev:mainfrom
TheDevMinerTV:fix/german-i18n-a11y-barrier-hit
Open

fix(i18n): german translation for "hit" in a11y section + missing keys#1493
TheDevMinerTV wants to merge 3 commits intonpmx-dev:mainfrom
TheDevMinerTV:fix/german-i18n-a11y-barrier-hit

Conversation

@TheDevMinerTV
Copy link

@TheDevMinerTV TheDevMinerTV commented Feb 14, 2026 •
edited
Loading

stößt was missing an ö.

Also added missing German translation keys for the trends section (untranslated version below):

image

@vercel
Copy link

vercel bot commented Feb 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 14, 2026 1:28am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 14, 2026 1:28am
npmx-lunaria Ignored Ignored Feb 14, 2026 1:28am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 14, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This pull request updates German localisation files to add two new translation keys under the Trends section (trends.contributors_skip and trends.items.contributors) and corrects a German spelling/umlaut in contact.p1 (changing "stoßt" to "stößt"). Changes are limited to i18n data; no functional or control-flow modifications were made.

Possibly related PRs

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description directly addresses the changeset by explaining the correction of a missing umlaut in 'stößt' and the addition of missing German translation keys for the trends section.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv marked this pull request as draft February 14, 2026 01:11
@TheDevMinerTV
Copy link
Author

TheDevMinerTV commented Feb 14, 2026 •
edited
Loading

@trueberryless Can you check if the singular / plural translations make sense?

Do we need to use the {count} variable in there for plural stuff?

EDIT: Seems fine

image

@TheDevMinerTV TheDevMinerTV changed the title fix(i18n): german translation for "hit" in a11y section fix(i18n): german translation for "hit" in a11y section + missing keys Feb 14, 2026
@TheDevMinerTV TheDevMinerTV force-pushed the fix/german-i18n-a11y-barrier-hit branch from aa6cc43 to 657d845 Compare February 14, 2026 01:26
@TheDevMinerTV TheDevMinerTV marked this pull request as ready for review February 14, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheDevMinerTV